Add DayOfYear, DayOfMonth, DayOfWeek Functions #2467
Merged
+1,054
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinHai-CN
changed the title
JinHai-CN
reviewed
Jan 16, 2025
JinHai-CN
reviewed
Jan 16, 2025
JinHai-CN
reviewed
Jan 16, 2025
src/function/scalar/day_of_week.cpp
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| module; | ||
| #include <__chrono/weekday.h> |
There was a problem hiding this comment.
Why the header file look so weird?
JinHai-CN
reviewed
Jan 16, 2025
|
|
||
| module; | ||
|
|
||
| import stl; |
There was a problem hiding this comment.
move import after 'export module day_of_month;'
JinHai-CN
reviewed
Jan 16, 2025
src/function/scalar/day_of_week.cppm
Outdated
|
|
||
| module; | ||
|
|
||
| import stl; |
There was a problem hiding this comment.
move import after 'export module xxxx'
JinHai-CN
reviewed
Jan 16, 2025
src/function/scalar/day_of_year.cppm
Outdated
|
|
||
| module; | ||
|
|
||
| import stl; |
There was a problem hiding this comment.
move import after 'export module xxxx'
JinHai-CN
reviewed
Jan 16, 2025
| @@ -59,6 +59,8 @@ struct DateTypeStd { | |||
| static bool Subtract(DateTypeStd input, IntervalType interval, DateTypeStd &output); | |||
|
|
|||
| static int64_t GetDatePart(DateTypeStd input, TimeUnit unit); | |||
|
|
|||
| static bool OuterDate2YMD(int32_t days, std::chrono::year_month_day &ymd); | |||
JinHai-CN
reviewed
Jan 16, 2025
| @@ -108,4 +108,14 @@ bool DateTimeType::IsDateTimeValid(int32_t year, int32_t month, int32_t day, int | |||
| return TimeType::IsTimeValid(hour, minute, second) and DateType::IsDateValid(year, month, day); | |||
| } | |||
|
|
|||
|
|
|||
| bool DateTimeType::OuterDateTime2YMD(int32_t days, std::chrono::year_month_day &ymd) { | |||
| int32_t year, month, day; | |||
JinHai-CN
approved these changes
Jan 16, 2025
JinHai-CN
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Ad DayOfYear, DayOfMonth, DayOfWeek Functions
Issue link: (#2033)
Type of change