Remove unused benchmark and test scripts; Update SDK version #424
+55
−623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused benchmark scripts and test files have been removed from the repository. This cleanup helps maintain the focus on currently relevant scripts and avoids potential confusion from the presence of obsolete or irrelevant code.
Refactored sqllogictest.py to better handle errors by using the subprocess module and printing error messages when commands fail. Additionally, updated test_basic.py to add more precise testing conditions and adjust the directory for csv data file in the testing framework.
This commit not only simplifies the error handling in the file `sqllogictest.py` by eliminating redundant print statements but also increases the version of our project in the `pyproject.toml` file. Additionally, the instructions and command syntax have been updated in the benchmark documentation to use the new script names, specifying the optional parameter value for better clarity and accuracy.
|
@mergify queue |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at bc89d40 |
yuzhichang
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add corresponding issue link with summary if exists -->
Issue link:
What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer