Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload file need use privious pos #79

Merged
merged 2 commits into from
Feb 12, 2025
Merged

fix: reload file need use privious pos #79

merged 2 commits into from
Feb 12, 2025

Conversation

luohoufu
Copy link
Contributor

What does this PR do

This pull request includes a small but important change to the modules/queue/disk_queue/consumer.go file. The change ensures that the read position is reset to the previous position when an invalid message size is detected, which helps to handle partial file loads more gracefully.

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@luohoufu luohoufu requested review from medcl and silenceqi February 11, 2025 08:50
Copy link
Member

@medcl medcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good catch.

@medcl medcl merged commit ff01bf6 into main Feb 12, 2025
3 of 4 checks passed
@medcl medcl deleted the fix_consumer_patch-2 branch February 12, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants