Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix path walk warn when tmp rename #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luohf-infinilabs
Copy link
Contributor

@luohf-infinilabs luohf-infinilabs commented Feb 14, 2025

What does this PR do

This pull request includes changes to the lib/status/path.go file to improve error handling and code readability. The most important changes include reordering imports and modifying the DirSize function to handle errors more gracefully.

Improvements to error handling and code readability:

  • lib/status/path.go: Reordered imports to follow Go conventions.
  • lib/status/path.go: Modified the DirSize function to continue walking the directory and ignore errors for non-root paths, improving robustness.

Rationale for this change

image

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant