Lower limit to maximum value in MomentsClient #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moments API lowered the maximum accepted value for the limit parameter to a 100, refusing requests with a higher number set for the limit
mbmjertan
added
bugfix
piqusy
approved these changes
Jan 7, 2025
iruzevic
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moments API lowered the maximum accepted value for the limit parameter to a 100, refusing requests with a higher number set for the limit.
This caused Forms to crash while loading Moments forms, returning an empty form selector. We did not notice it earlier because of a transient being present.
Screenshots / Videos
N/A
Linked documentation PR
N/A