-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: start whats'new #287
Conversation
Deploying fluvio-docs-nightly with Cloudflare Pages
|
71be590
to
af9cc0a
Compare
744ae36
to
835af13
Compare
835af13
to
00b19b8
Compare
00b19b8
to
bc5ceeb
Compare
@@ -91,172 +91,10 @@ The sections are as follows: | |||
* `functions` - defines functions in the package | |||
* `dev` - defines substitutions used during development and test | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is "Build and Test a Package" removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is duplicated in Quickstart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep in package and remove in Quickstart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to follow the current docs.
First did https://www.fluvio.io/sdf/composition/overview and then https://www.fluvio.io/sdf/composition/quickstart
When I was in quickstart I got annoyed because it was exactly the same of the last part of overview. Are you suggesting to remove quickstart and only keep all in overview?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see. Yes, the Overview should be concepts and no code (no step-by-step). I didn't realize that part was duplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is the quickstart for composition, not the quickstart for sdf, Should I remove it? since in composition, inline is not allowed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated my comment above ☝️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is a nit. We should swap these 2 commands:
Create then shutdown. |
This is for upgrading worker which implies that worker already exists |
Good point, I should have read the description above. |
Updates for new release