Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: start whats'new #287

Merged
merged 5 commits into from
Oct 28, 2024
Merged

chore: start whats'new #287

merged 5 commits into from
Oct 28, 2024

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Oct 28, 2024

Updates for new release

Copy link

cloudflare-workers-and-pages bot commented Oct 28, 2024

Deploying fluvio-docs-nightly with  Cloudflare Pages  Cloudflare Pages

Latest commit: a537600
Status: ✅  Deploy successful!
Preview URL: https://78ea9912.fluvio-docs-15u.pages.dev
Branch Preview URL: https://start-whatsnew.fluvio-docs-15u.pages.dev

View logs

@morenol morenol requested a review from sehz October 28, 2024 16:43
sdf/composition/quickstart.mdx Outdated Show resolved Hide resolved
sdf/composition/quickstart.mdx Outdated Show resolved Hide resolved
sdf/whatsnew.mdx Outdated Show resolved Hide resolved
sdf/whatsnew.mdx Outdated Show resolved Hide resolved
sdf/whatsnew.mdx Outdated Show resolved Hide resolved
sdf/whatsnew.mdx Outdated Show resolved Hide resolved
@@ -91,172 +91,10 @@ The sections are as follows:
* `functions` - defines functions in the package
* `dev` - defines substitutions used during development and test


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is "Build and Test a Package" removed?

Copy link
Contributor Author

@morenol morenol Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is duplicated in Quickstart

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep in package and remove in Quickstart.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to follow the current docs.

First did https://www.fluvio.io/sdf/composition/overview and then https://www.fluvio.io/sdf/composition/quickstart

When I was in quickstart I got annoyed because it was exactly the same of the last part of overview. Are you suggesting to remove quickstart and only keep all in overview?

Copy link
Contributor

@ajhunyady ajhunyady Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see. Yes, the Overview should be concepts and no code (no step-by-step). I didn't realize that part was duplicated.

Copy link
Contributor Author

@morenol morenol Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is the quickstart for composition, not the quickstart for sdf, Should I remove it? since in composition, inline is not allowed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated my comment above ☝️

@morenol morenol requested a review from sehz October 28, 2024 18:54
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@morenol morenol merged commit 36c3834 into main Oct 28, 2024
2 checks passed
@morenol morenol deleted the start-whatsnew branch October 28, 2024 19:15
@ajhunyady
Copy link
Contributor

This is a nit. We should swap these 2 commands:

$ sdf worker shutdown <host-worker-name>
$ sdf worker create <host-worker-name>

Create then shutdown.

@sehz
Copy link
Contributor

sehz commented Oct 28, 2024

This is for upgrading worker which implies that worker already exists

@ajhunyady
Copy link
Contributor

This is for upgrading worker which implies that worker already exists

Good point, I should have read the description above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants