feat: Implement Deserialize for Catalog #25730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fairly easy all things considered. We needed to turn on the serde feature for parking_lot, remove the Serialize impl, derive both it and Deserialize, and add the flatten attribute and we're all set. The output for the tests changed, but only the order of fields, not the actual content so it's fine that we updated them. This change will allow us to deserialize the Catalog in the future if need be without running into issues around the fact that it can't implement it. Closes #25574
mgattozzi
requested review from
pauldix,
hiltontj,
jacksonrnewhouse and
praveen-influx
hiltontj
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
It would be nice if we could remove the need to de/serialize the db_map attribute, as #25574 describes, but since there are only ever 5 max DBs leaving it in is not a big deal.
My only suggestion would be to leave #25574 open and update the description to say the alternative was resolved, so we can deal with that bit of cleanup later. Removing the db_map from the serialized form should be a backward compatible change also, so not urgent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fairly easy all things considered. We needed to turn on the serde feature for parking_lot, remove the Serialize impl, derive both it and Deserialize, and add the flatten attribute and we're all set. The output for the tests changed, but only the order of fields, not the actual content so it's fine that we updated them. This change will allow us to deserialize the Catalog in the future if need be without running into issues around the fact that it can't implement it.
Closes #25574