Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create S3 client with from_env() instead of new() to allow eks and fargate container builds #25829

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: create S3 client with from_env() instead of new() to allow eks and fargate container builds #25829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions influxdb3_clap_blocks/src/object_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ macro_rules! object_store_config_inner {
pub fn s3_builder(&self) -> object_store::aws::AmazonS3Builder {
use object_store::aws::AmazonS3Builder;

let mut builder = AmazonS3Builder::new()
let mut builder = AmazonS3Builder::from_env()
.with_client_options(self.client_options())
.with_allow_http(self.aws_allow_http)
.with_region(&self.aws_default_region)
Expand Down Expand Up @@ -623,7 +623,7 @@ macro_rules! object_store_config_inner {
return Ok(None);
};

let store = object_store::aws::AmazonS3Builder::new()
let store = object_store::aws::AmazonS3Builder::from_env()
// bucket name is ignored by our cache server
.with_bucket_name(self.bucket.as_deref().unwrap_or("placeholder"))
.with_client_options(
Expand Down
Loading