Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load plugins from our github plugin repo #25861

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

pauldix
Copy link
Member

@pauldix pauldix commented Jan 17, 2025

Adds the ability to load a plugin from our public github repo here: https://github.com/influxdata/influxdb3_plugins

If the plugin filename is specified as gh:examples/wal_plugin it will pull from the github repo at <dir>/<name>/<name>.py.

Currently this test actually hits github to pull the file. Not sure what we want to do here to mock it out. Or do we?

Closes #25836

Adds the ability to load a plugin from our public github repo here: https://github.com/influxdata/influxdb3_pluginshttps://github.com/influxdata/influxdb3_plugins

If the plugin filename is specified as `gh:examples/wal_plugin` it will pull from the github repo at `<dir>/<name>/<name>.py`.

Closes #25836
@jacksonrnewhouse
Copy link
Contributor

Should this specify a branch on github?

@pauldix
Copy link
Member Author

pauldix commented Jan 17, 2025

It pulls it from main. We could change it later to be able to pull from specific branch or commit, but I don't want to worry about that for now.

@pauldix pauldix merged commit b39b48a into main Jan 17, 2025
14 checks passed
@pauldix pauldix deleted the pd/load-plugin-gh branch January 17, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install or test plugin from public repository
2 participants