feat: persist snapshots in parallel #25901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgattozzi
requested review from
pauldix,
waynr,
hiltontj,
jacksonrnewhouse and
praveen-influx
pauldix
approved these changes
Jan 23, 2025
This speeds up snapshot persistence by taking all of the persist jobs and running them simultaneously on a JoinSet. With this we can speed things up a bit by not waiting for each file to persist before the next one can be persisted. Instead we now can run all the persisting at the same time using the tokio runtime. Closes #24658
mgattozzi
force-pushed
the
mgattozzi/parallel-persist-job
branch
from
3cd8914 to
2601ac6
Compare
|
Had to fix the conflicts but this should be good to merge again once it passes ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up snapshot persistence by taking all of the persist jobs and running them simultaneously on a JoinSet. With this we can speed things up a bit by not waiting for each file to persist before the next one can be persisted. Instead we now can run all the persisting at the same time using the tokio runtime.
Closes #24658