feat(processing_engine): Implement Processing Engine Cache. #26111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldix
approved these changes
Mar 10, 2025
|
|
||
| #[getter] | ||
| fn cache(&self) -> PyResult<PyCache> { | ||
| GLOBAL_CACHE_STORE |
| false | ||
| } | ||
|
|
||
| fn cleanup(&mut self) { |
There was a problem hiding this comment.
this function seems like it's going to be problematic if we get into a situation with many keys in the cache. Might not be a problem, but something to look out for. Figuring out some way to look for expirations without holding a write lock might be good for later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26093.
This implements caches that are available to plugin code in-line with the specs in the ticket. In particular, users can store any python objects under a string key, storing it either to the "global" or "local" cache, where the local cache is namespaced to the individual trigger. Additionally, for the test endpoints those will be swapped in for namespaced caches with a fallback TTL of 30 minutes.
This is currently working, only things left to do are write tests and delete caches when triggers are disabled or deleted.