-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downloadable font: rejected by sanitizer #2629
Comments
One possible lead to explore is the pathing for font assets, as explained here: https://www.seanmcp.com/articles/fix-downloadable-font-rejected-by-sanitizer-error-in-firefox/ |
I saw this error in chrome:
maybe doing a couple of searches and cross referencing the results is the way to go? |
We tried removing |
Crazy idea: what if we deleted all references to 'icomoon' in the UI repository? Since 'icomoon' is already (and should be) handled by Clockface, why is it necessary to reference 'icomoon' directly in the UI repository stylesheets? Perhaps this error is from the 3 stray references to 'icomoon'? Which appear to do nothing or add very little to styling for components that will no longer be used. |
To remove all references of 'icomoon', we need to:
|
Didn't work. Still getting the sanitizer error in Tools after deployment. |
We are back to this being a clockface problem The reason is because clockface uses two other fonts with woff2 files that do not throw this error in the console. This only happens with icomoon. |
Attempts to use only one of the file formats and deleting the rest from In Chrome:
In Firefox:
|
At this point, it seems likely that the .woff, .woff2, and .ttf files for icomoon in Clockface are incorrect or corrupt in some way. Although I do not have specifics on exactly what's wrong with them. |
Update: the previous test locally was not done correctly. Any unused font files should be deleted, which they were not for the test, because Clockface's rollup with attempt to build all font files regardless of being used or not. Will attempt another test and report back. |
Still does not work. It appears that icomoon.eot and icomoon.svg either links or refers (imports) to the other three files that end with .woff, .woff2, and .ttf |
This is actually a Giraffe problem. The filenames that Firefox complains about can be found in Giraffe's dist folder |
Still not working. |
The error message "downloadable font rejected by sanitizer" still appears in the console, even though the request is now a 200. Looks like the fetching of the asset is fine but the format or interpretation of the woof, woff2, and ttf files in Giraffe is still incorrect. |
One way to solve this issue is to ask Giraffe to bundle all of its CSS into a single file, similar to what Clockface already does. This will allow the static assets in the CSS to be put into the correct folder during build time. Closing this issue in favor of influxdata/giraffe#686 |
The console is spitting out errors regarding the "icomoon" font. Previously this was reported as #1673 - but the issue remains unresolved.
The text was updated successfully, but these errors were encountered: