Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove all references to "icomoon" #2840

Merged
merged 2 commits into from
Oct 8, 2021
Merged

fix: remove all references to "icomoon" #2840

merged 2 commits into from
Oct 8, 2021

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Oct 8, 2021 •
edited
Loading

Closes #2629

  • CustomSingularTime.scss is not used DELETED
  • Delete the import of CustomSingularTime.scss in chronograf.scss
  • TableGraphs.scss - change "icomoon" to $cf-text-font temporarily (only visible when useGiraffeGraphs is off)
  • variables.scss - $ix-icon-font is not used

@TCL735 TCL735 requested a review from a team as a code owner October 8, 2021 20:34
hoorayimhelping
hoorayimhelping approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TCL735
Copy link
Contributor Author

TCL735 commented Oct 8, 2021

Changes are safe. Let's see if this works in addressing the issue.

@ui-ci-bot-influx
Copy link

Metric Score Level
performance 63 🟡
accessibility 96 🟢
seo 90 🟢
pwa null 💩
best-practices 100 🟢

Compare your scores with master branch

@TCL735 TCL735 merged commit 3e760fd into master Oct 8, 2021
@TCL735 TCL735 deleted the fix_2629_font_sanitizer branch October 8, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downloadable font: rejected by sanitizer
3 participants
@TCL735 @ui-ci-bot-influx @hoorayimhelping