fix(test/relayer): missing consensus state in light_client
#256
Conversation
|
My suggestion in the issue was wrong. I found the main cause. We build the client update payload from Cosmos not exactly at target_height. It actually recalls create-client-payload to create a header for the whatever-is-latest height at that moment. Not really sure why we are not reusing the client-update-payload-builder implementation from hermes-sdk. It does reuse the create-client-payload-builder from hemres-sdk. |
|
Because we currently don't have |
| @@ -182,6 +182,14 @@ impl From<CometClientState> for Any { | |||
| } | |||
| } | |||
|
|
|||
| impl From<CometClientState> for IbcCometClientState { | |||
There was a problem hiding this comment.
Can't we just convert the two values directly? Or can we just use TendermintClientState as the type when interacting with the Cairo contract?
There was a problem hiding this comment.
Good point ! We can use the types directly 👍🏽
There was a problem hiding this comment.
Let's tackle this in a separate issue.
We need to reuse Tendermint header, client and consensus state.
| starknet_to_cosmos_relay | ||
| .send_target_update_client_messages(SourceTarget, &cosmos_status.height) | ||
| .await?; | ||
|
|
||
| // wait till the starknet_status is incremented | ||
| while starknet_status.height <= starknet_height { |
There was a problem hiding this comment.
What is this waiting for? Is the devnet not progressing right after a Call is processed?
There was a problem hiding this comment.
yes. but I can delete it. I thought that was the main bug at first.
closes #241