Updated the grammar rules to allow for optional trailing commas. #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugarela
reviewed
Sep 23, 2024
MahtabNorouzi
changed the title
min function in superspec.map.json to demonstrate this change while keeping the add function unchanged for reference. - Added an import statement: import Proto(N = N,) as Inst1. ### Details - The min function now accepts parameters in the following formats: - (x: int, y: int,) - (x: int, y: int) - The import statement is included to utilize the Proto module with an optional trailing comma. ### Reason for Changes - Allowing an optional trailing comma makes the syntax more flexible and consistent with common programming practices. ### Test Cases - Added test cases for both scenarios in superspec.map.json to ensure correct parsing of functions with optional trailing commas.
MahtabNorouzi
changed the title
min function in superspec.map.json to demonstrate this change while keeping the add function unchanged for reference. - Added an import statement: import Proto(N = N,) as Inst1. ### Details - The min function now accepts parameters in the following formats: - (x: int, y: int,) - (x: int, y: int) - The import statement is included to utilize the Proto module with an optional trailing comma. ### Reason for Changes - Allowing an optional trailing comma makes the syntax more flexible and consistent with common programming practices. ### Test Cases - Added test cases for both scenarios in superspec.map.json to ensure correct parsing of functions with optional trailing commas.
MahtabNorouzi
changed the title
MahtabNorouzi
changed the title
Summary of Changes
Details
Reason for Changes
Test Cases
|
|
Actually, I remembered something else: we should add an entry to CHANGELOG.md saying that we now allow trailing commas in operator definitions and constant initialization - which also makes me think we might have missed one case: operator call. We should be able to call |
bugarela
reviewed
Oct 3, 2024
CHANGELOG.md
Outdated
|
|
||
| - Updated grammar rule to allow an optional trailing comma in parameter lists: | ||
|
|
||
| - Function calls |
There was a problem hiding this comment.
Suggested change
| - Function calls | |
| - Operator calls |
bugarela
approved these changes
Oct 3, 2024
Co-authored-by: Gabriela Moreira <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdfor any new functionalityREADME.mdupdated for any listed functionality