Terminate Apalache server on Linux properly #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugarela
approved these changes
Oct 2, 2024
|
@bugarela Amazing! It looks like you have to merge it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running massive experiments on a Linux machine, I have noticed that the instances of Apalache server are spawned via
quint verifybut not properly terminated. This is especially visible when running multiple model checking instances in parallel. In the end, the machine runs out of swap space.The main reason for that is spawning
apalache-mcvia shell from NodeJS, which does not terminate the grandchild process (java). This PR simply changes the spawning optionshelltofalse. I have checked it on a Linux machine. Now the server is terminating.CHANGELOG.mdfor any new functionality