Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find the expert extend search capability #151

Conversation

JefQuidousse2
Copy link
Contributor

No description provided.

@JefQuidousse2 JefQuidousse2 marked this pull request as draft October 4, 2024 13:47
@lucacelea
Copy link
Contributor

The technology query has to exactly match to spit out results. I would rather the query does a like or a contains type of search instead of an exact (albeit case-insensitive) match.

@lucacelea
Copy link
Contributor

The Submit button seems a bit dated. Can we instead make the filter filter as you type? Buffered of course.

@lucacelea
Copy link
Contributor

Can you place these filters next to each other horizontally? Vertical space is precious, horizontal space not so much.

@lucacelea
Copy link
Contributor

Can you run the linter locally and fix whatever it spits out?

@lucacelea
Copy link
Contributor

This PR also includes the changes for the usage metrics. Can you revert the commit?

@JefQuidousse2 JefQuidousse2 marked this pull request as ready for review October 25, 2024 10:47
@lucacelea lucacelea self-requested a review November 7, 2024 20:25
src/components/ui/search-expert.tsx Outdated Show resolved Hide resolved
src/components/ui/search-expert.tsx Outdated Show resolved Hide resolved
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
src/app/result/[role]/page.tsx Outdated Show resolved Hide resolved
src/app/result/[role]/page.tsx Outdated Show resolved Hide resolved
src/components/show-data-table.tsx Outdated Show resolved Hide resolved
@JarneVanAerde JarneVanAerde merged commit f1776f2 into infosupport:main Dec 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants