Add Initial Prom Metrics For Load Balancer Count #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dejon Gill <[email protected]>
nicolerenee
reviewed
Dec 7, 2023
internal/srv/prom.go
Outdated
| prometheus.GaugeOpts{ | ||
| Subsystem: subsystem, | ||
| Name: "load_balancers_count", | ||
| Help: "Total count of currently deployed load balancers", |
There was a problem hiding this comment.
On restart this would get reset to zero and it looks like you only increment when creating a new load balancer. So this could actually end up becoming a negative number. Unless I'm missing something. Might be better to add a counter for created load balancers and deleted load balancers.
There was a problem hiding this comment.
So this could actually end up becoming a negative number. Unless I'm missing something. Might be better to add a counter for created load balancers and deleted load balancers.
🤦 I think 7783e21 handles this bit.
On restart this would get reset to zero
I'm actually not sure about how to address this
Signed-off-by: Dejon Gill <[email protected]>
Signed-off-by: Matt Siwiec <[email protected]>
Signed-off-by: Matt Siwiec <[email protected]>
…locations (infratographer#170) * √√ on create deployment if lb location is in operator watched locations Signed-off-by: Matt Siwiec <[email protected]> * changes test needs location Signed-off-by: Matt Siwiec <[email protected]> --------- Signed-off-by: Matt Siwiec <[email protected]>
* publish metering event Signed-off-by: Stephen Hwang <[email protected]> * use changeset instead of eventtype Signed-off-by: Stephen Hwang <[email protected]> * use EventMessage Signed-off-by: Stephen Hwang <[email protected]> * remove extraneous config, add warn Signed-off-by: Stephen Hwang <[email protected]> * bump go Signed-off-by: Stephen Hwang <[email protected]> * Update Dockerfile Signed-off-by: sthwang-metal <[email protected]> * Update Dockerfile Signed-off-by: sthwang-metal <[email protected]> * Update Dockerfile Signed-off-by: sthwang-metal <[email protected]> --------- Signed-off-by: Stephen Hwang <[email protected]> Signed-off-by: sthwang-metal <[email protected]>
Signed-off-by: Dejon Gill <[email protected]>
Signed-off-by: Dejon Gill <[email protected]>
rizzza
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/metricsendpoint