inverse cpu and rust wrappers #747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonHibnik
reviewed
Jan 23, 2025
| @@ -24,6 +24,7 @@ enum VecOperation { | |||
| VECTOR_SUB, | |||
| VECTOR_MUL, | |||
| VECTOR_DIV, | |||
| VECTOR_INV, | |||
There was a problem hiding this comment.
Can break code compatibility? should add as last and a TODO to re-order on next major
There was a problem hiding this comment.
It's internal code of CPU backend. I don't think anyone is using it, especially since it is a cpp file, not a header.
yshekel
reviewed
Feb 5, 2025
| @@ -69,6 +69,12 @@ pub trait VecOps<F> { | |||
| cfg: &VecOpsConfig, | |||
| ) -> Result<(), eIcicleError>; | |||
|
|
|||
| fn inv( | |||
| a: &(impl HostOrDeviceSlice<F> + ?Sized), | |||
There was a problem hiding this comment.
suggest renaming a->input and result->output or something other than a,result
yshekel
reviewed
Feb 5, 2025
| @@ -371,6 +377,19 @@ where | |||
| <<F as FieldImpl>::Config as VecOps<F>>::div(a, b, result, &cfg) | |||
| } | |||
|
|
|||
| pub fn inv_scalars<F>( | |||
| a: &(impl HostOrDeviceSlice<F> + ?Sized), | |||
yshekel
approved these changes
Feb 5, 2025
LeonHibnik
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuda-backend-branch: emir/inverse