Miki/msm-optimiations #794
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
reviewed
Mar 2, 2025
| @@ -42,22 +42,28 @@ class Msm | |||
| } | |||
|
|
|||
| // run MSM based on pippenger algorithm | |||
| void run_msm(const scalar_t* scalars, const A* bases, P* results) | |||
| void run_msm(const scalar_t* scalars, const A* bases, P* results, bool last_task_on_batch) | |||
There was a problem hiding this comment.
I think it's last_task_in_batch? instead of on_batch
yshekel
reviewed
Mar 2, 2025
| phase3_final_accumulator(results); | ||
| m_phase3_thread = nullptr; | ||
| } else { | ||
| m_phase3_thread = new std::thread(&Msm::phase3_final_accumulator, this, results); |
There was a problem hiding this comment.
I don't see that you release it so you leak memory. Why not a unique_ptr? you can still have it nullptr
yshekel
reviewed
Mar 2, 2025
| @@ -217,18 +226,35 @@ class Msm | |||
| } | |||
| } | |||
|
|
|||
| // // phase 2: accumulate m_segment_size buckets into a line_sum and triangle_sum | |||
yshekel
requested changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid scalar copy
improve c formula