-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically generate main file for unit tests #653
Automatically generate main file for unit tests #653
Conversation
I believe with this change |
cd8c684
to
2ae707c
Compare
@bartlomieju Thanks for the changes! I made a couple of changed and amended those to your commit, then pushed it to your fork. I figured this was easier than writing a whole bunch of comments which you'd then have to piece together into actual code. These changes are largely style related, and the general idea of your implementation was fine 😄 I made the following changes:
You can see the exact list of changes here. I'll merge the PR some time tomorrow in case I think of anything else overnight. |
Totally and thanks! These changes make sense - since it's my first PR to the project I played it safe and erred on the verbose side :)
Nice catch, I completely missed that!
SGTM; I assume you are going to delete |
And this is exactly why I wanted to wait with merging, I forgot about doing just that. Thanks for the reminder 😄 |
This commit implements automatic generation of the main file (inko-tests.inko) for running unit tests. This file is placed in the build/ directory and is regenerated on each run. The file is not removed after the tests are run to allow inspection. Changelog: added
2ae707c
to
da6ea1c
Compare
@bartlomieju Thanks! |
This commit implements automatic generation of the main file (inko-tests.inko) for running unit tests. This file is placed in the build/ directory and is regenerated on each run. The file is not removed after the tests are run to allow inspection.
Changelog: added
Closes #575