Disallow symbol imports from another module #655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a compiler bug that allowed to import symbols that were not defined in the module, but only imported from another module. Changelog: fixed
yorickpeterse
requested changes
Nov 16, 2023
Please squash me into the initial commit once done :) Add tests for all cases of `ModuleId::import_symbol`
bartlomieju
force-pushed
the
disallow_importing_symbols_from_another_mod
branch
from
e561b04 to
f37d924
Compare
yorickpeterse
approved these changes
Nov 20, 2023
|
This has been rebased into b3783be. Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a compiler bug that allowed to import symbols that were not defined in the module, but only imported from another module.
Changelog: fixed
Closes #603