feat: improve streeet search api #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabauke
force-pushed
the
fix-street-search-lang-2
branch
4 times, most recently
from
f87bcb3 to
0cfb04b
Compare
|
@czosel sorry for the noise. Now it's really ready. :-) |
luytena
reviewed
Apr 18, 2024
derrabauke
force-pushed
the
fix-street-search-lang-2
branch
from
0cfb04b to
9ec0476
Compare
czosel
reviewed
Jul 3, 2024
|
Otherwise LGTM, nice work! 💯 |
derrabauke
force-pushed
the
fix-street-search-lang-2
branch
from
9ec0476 to
127e880
Compare
If the first search request for a certain street name yieled no results the service will retry with all available languages to search for it.
derrabauke
force-pushed
the
fix-street-search-lang-2
branch
from
127e880 to
f1a120b
Compare
czosel
approved these changes
Jul 17, 2024
|
🎉 This PR is included in version 7.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #741
Second part of #738
Multilingual street search
If no streets are found, try the other available languagesUpdate after short discussion with @czosel:
We want to stay very defensive with caching and fire one or two requests more rather then getting trapped in some request cache shenanigans. Opting for only canton relevant languages will most effectively cut down request count.