Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-gateway): Add OpenAPI Examples and enforce error #1787

Draft
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Feb 5, 2025

Description

Added OpenAPI Examples and enforce error.

  • Added missing examples accordingly.
  • Modified the spectral linter rules to mark missing examples from properties and schemas as an error instead of warning.
  • Added derive_more with certain enabling features to reduce code boilerplate for implementing newtypes traits.
  • Added new types ApiDateTime, Hash128, modified Hash to Hash256.
  • Removed unused types service/api/cardano/types.rs as creating newtypes to work with.
  • Removed unused files along the way service/common/objects/cardano/registration_info.rs and service/common/objects/cardano/sync_state.rs.
  • Resolved 🛠️ [TASK] : Recheck validation value #239

Related Issue(s)

Closes #1783

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Feb 5, 2025
@apskhem apskhem linked an issue Feb 5, 2025 that may be closed by this pull request
4 tasks
@apskhem apskhem marked this pull request as draft February 5, 2025 13:22
@apskhem apskhem added draft Draft rust Pull requests that update Rust code labels Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test Report | ${\color{lightgreen}Pass: 467/467}$ | ${\color{red}Fail: 0/467}$ |

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test Report | ${\color{lightgreen}Pass: 467/467}$ | ${\color{red}Fail: 0/467}$ |

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test Report | ${\color{lightgreen}Pass: 467/467}$ | ${\color{red}Fail: 0/467}$ |

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Test Report | ${\color{lightgreen}Pass: 467/467}$ | ${\color{red}Fail: 0/467}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 475/480}$ | ${\color{red}Fail: 0/480}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 475/480}$ | ${\color{red}Fail: 0/480}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 475/480}$ | ${\color{red}Fail: 0/480}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 487/492}$ | ${\color{red}Fail: 0/492}$ |

@apskhem apskhem added draft Draft and removed review me PR is ready for review labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Draft rust Pull requests that update Rust code
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Fix missing examples from API 🛠️ [TASK] : Recheck validation value
1 participant