-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load ARIA-tools generated ionosphere stack from the template file #1328
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces the ability to load ionosphere data from a template file using the Sequence diagram for loading ionosphere data with load_data.pysequenceDiagram
participant User
participant load_data.py
participant mintpy.load.ionUnwFile
User->>load_data.py: Executes load_data.py with --iono option
load_data.py->>mintpy.load.ionUnwFile: Reads ionosphere data from file specified by --iono
mintpy.load.ionUnwFile-->>load_data.py: Returns ionosphere data
load_data.py-->>User: Completes data loading
Sequence diagram for loading ionosphere stack with prep_aria.pysequenceDiagram
participant prep_aria.py
participant writefile.layout_hdf5
prep_aria.py->>writefile.layout_hdf5: Writes ionosphere stack to ionStack.h5
writefile.layout_hdf5-->>prep_aria.py: Completes writing
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ehavazli - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test for the new
--iono
option inload_data.py
. - The bug fix in
prep_aria.py
looks good, but could benefit from a brief comment explaining the original issue.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
--iono
option toload_data.py
arguments so when ionosphere file is given in the template, theload_data
step will read theionoStack.vrt
.prep_aria.py
which was causing the script to skip loading toionStack.h5
Summary by Sourcery
Adds the ability to load ARIA-tools generated ionosphere stack from the template file using the
--iono
option inload_data.py
. Fixes a bug inprep_aria.py
that prevented loading toionStack.h5
.New Features:
--iono
option toload_data.py
arguments so when ionosphere file is given in the template, theload_data
step will read theionoStack.vrt
.Bug Fixes:
prep_aria.py
which was causing the script to skip loading toionStack.h5