autoget.ECMWFdload(): bugfix for snwe in numpy.int64 or float

[yunjunz]

• autoget.ECMWFdload(): bugfix if input snwe is in numpy.int64 or float, as reported in new pyaps0.3.6 can not download dataset MintPy#1321

• README: collapse dev install note for a simpler first look

Summary by Sourcery

Fix bug in ECMWFdload for handling snwe parameter with incorrect types and improve the README by collapsing the developer installation notes for better readability.

Bug Fixes:

• Fix a bug in autoget.ECMWFdload() where the snwe parameter was not handled correctly when provided as numpy.int64 or float types. The function now converts these types to native integers and prints a warning if the conversion results in a change of area to prevent unexpected behavior downstream.

Documentation:

• Collapse the developer installation notes in the README for a cleaner first look, making it easier for new users to get started with the project. The detailed instructions are still available via an expandable section.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses an issue in autoget.ECMWFdload() related to the snwe input type, ensuring it's correctly handled as native integers. Additionally, it improves the README by collapsing the detailed development installation instructions for better readability.

Updated class diagram for ECMWFdload function

classDiagram
    class ECMWFdload {
        +bdate
        +hr
        +filedir
        +model
        +datatype
        +humidity
        +snwe
        +ECMWFdload(bdate, hr, filedir, model, datatype, humidity, snwe)
        +ensure_snwe_is_native_int(snwe)
    }
    note for ECMWFdload "Ensures snwe is in native int, not numpy.int32/64 or float etc."

Loading

File-Level Changes

Change	Details	Files
Fixes a bug in autoget.ECMWFdload() where the snwe input, when provided as numpy.int64 or float, would cause issues.	Ensures the snwe input is converted to native Python integers. Adds a warning message if the input snwe coordinates are not integers, indicating conversion to the bounding box integer coordinates.	src/pyaps3/autoget.py
Collapses the development installation note in the README for a cleaner initial view.	Wraps the detailed development installation instructions within a collapsible <details> tag.	README.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[codeautopilot]

PR summary

This Pull Request addresses two main changes:

1. Bugfix in autoget.ECMWFdload(): The function now correctly handles the snwe parameter when it is provided as numpy.int64 or float. The fix ensures that snwe values are converted to native integers using the math.floor and math.ceil functions, which simplifies file naming and avoids potential issues with non-integer types. A warning is printed if the input area is not an exact integer, indicating the conversion to its bounding box in integer form.

2. README Update: The installation instructions for the development version of the software have been collapsed into a clickable details section. This change aims to streamline the README for a cleaner initial presentation, allowing users to expand the section for more information if needed.

These changes improve the robustness of the ECMWFdload function and enhance the readability of the documentation.

Suggestion

• Consider adding unit tests to verify the behavior of the ECMWFdload function with various snwe input types (e.g., numpy.int64, float, and native int). This would help ensure that the bugfix works as intended and prevent future regressions.

This comment was generated by AI. Information provided may be incorrect.

Current plan usage: 0%

Have feedback or need help?
Documentation
[email protected]

[sourcery-ai]

Hey @yunjunz - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a unit test to specifically cover the snwe input validation and conversion.
• The warning message could be improved to be more informative about the potential impact of the bounding box conversion.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}