-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update leap second table to 28 Dec 2025 based on IERS Bulletin C 69 #103
Update leap second table to 28 Dec 2025 based on IERS Bulletin C 69 #103
Conversation
According to IERS Bulletin C 69, no leap second will be introduced at the end of June 2025. The next possible insertion date is therefore the end of December 2025.
Reviewer's Guide by SourceryThis pull request updates the leap second table in Updated class diagram for leap second table parametersclassDiagram
class LeapSecondTable {
<<parameter>>
MJDUPPER: int
MJDLOWER: int
}
note for LeapSecondTable.MJDUPPER "Upper limit, leap second table, updated to 2025dec28"
note for LeapSecondTable.MJDLOWER "Lower limit, leap second table, 1972jan01"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
PR summaryThis Pull Request updates the leap second table in the Review Checklist
SuggestionNo specific suggestions for improvements are necessary, as the changes are straightforward and align with the latest official data. However, it might be beneficial to implement a mechanism to automatically update the leap second table based on future bulletins to reduce manual updates and potential errors. This comment was generated by AI. Information provided may be incorrect. Current plan usage: 0% Have feedback or need help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AndreHauschild - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why the MJDUPPER parameter was changed.
- It would be good to update the expiration date in the comments to reflect the new date.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @AndreHauschild.
According to IERS Bulletin C 69, no leap second will be introduced at the end of June 2025. The next possible insertion date is therefore the end of December 2025.
Summary by Sourcery
Enhancements: