Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update leap second table to 28 Dec 2025 based on IERS Bulletin C 69 #103

Merged

Conversation

AndreHauschild
Copy link
Contributor

@AndreHauschild AndreHauschild commented Feb 24, 2025

According to IERS Bulletin C 69, no leap second will be introduced at the end of June 2025. The next possible insertion date is therefore the end of December 2025.

Summary by Sourcery

Enhancements:

  • Update the leap second table to reflect the absence of a leap second at the end of June 2025, extending its validity until December 28, 2025.

According to IERS Bulletin C 69, no leap second will be introduced at
the end of June 2025. The next possible insertion date is therefore the
end of December 2025.
Copy link

sourcery-ai bot commented Feb 24, 2025

Reviewer's Guide by Sourcery

This pull request updates the leap second table in src/pysolid/solid.for to reflect the IERS Bulletin C 69, which indicates that no leap second will be introduced at the end of June 2025. The upper limit of the table is extended to December 28, 2025.

Updated class diagram for leap second table parameters

classDiagram
  class LeapSecondTable {
    <<parameter>>
    MJDUPPER: int
    MJDLOWER: int
  }

  note for LeapSecondTable.MJDUPPER "Upper limit, leap second table, updated to 2025dec28"
  note for LeapSecondTable.MJDLOWER "Lower limit, leap second table, 1972jan01"
Loading

File-Level Changes

Change Details Files
Update the leap second table's upper limit to December 28, 2025.
  • Increased the MJDUPPER parameter value from 60854 to 61037.
  • Updated the comment indicating the upper limit of the leap second table from June 28, 2025 to December 28, 2025.
  • Updated the file expiration date in the comments from June 28 2025 to December 28 2025.
src/pysolid/solid.for

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

codeautopilot bot commented Feb 24, 2025

PR summary

This Pull Request updates the leap second table in the solid.for file to reflect the latest information from IERS Bulletin C 69. The upper limit for the leap second table has been extended from June 28, 2025, to December 28, 2025, as no leap second will be introduced at the end of June 2025. The modification involves updating the MJDUPPER parameter to 61037 and correcting the expiration date in the comments. Additionally, a URL in the comments has been updated to use HTTPS for improved security. These changes ensure that the software remains accurate and up-to-date with the latest leap second data, which is crucial for precise timekeeping applications.

Review Checklist

  • Ensure that the updated leap second table aligns with the latest IERS Bulletin C 69.
  • Verify that the URL change to HTTPS does not affect any functionality or external dependencies.

Suggestion

No specific suggestions for improvements are necessary, as the changes are straightforward and align with the latest official data. However, it might be beneficial to implement a mechanism to automatically update the leap second table based on future bulletins to reduce manual updates and potential errors.

This comment was generated by AI. Information provided may be incorrect.

Current plan usage: 0%

Have feedback or need help?
Documentation
[email protected]

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AndreHauschild - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why the MJDUPPER parameter was changed.
  • It would be good to update the expiration date in the comments to reflect the new date.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @AndreHauschild.

@yunjunz yunjunz merged commit ddae45b into insarlab:main Feb 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants