Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scheduled job #234

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Fix Scheduled job #234

merged 8 commits into from
Jan 24, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 21, 2025

@m7pr m7pr added the core label Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@m7pr m7pr marked this pull request as draft January 21, 2025 13:33
@m7pr
Copy link
Contributor Author

m7pr commented Jan 21, 2025

I have read the CLA Document and I hereby sign the CLA

@m7pr
Copy link
Contributor Author

m7pr commented Jan 21, 2025

recheck

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Unit Tests Summary

  1 files   23 suites   1m 16s ⏱️
273 tests 267 ✅ 6 💤 0 ❌
856 runs  850 ✅ 6 💤 0 ❌

Results for commit 3e08a88.

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor Author

m7pr commented Jan 22, 2025

Since relying on testthat 3.0.1 yields to dependencies on

-> tidyr -> vdiffr 0.2.1 -> devtools 1.13.3 -> gdtools 0.1.6 

where the last one can not be installed, I updated testthat to 3.2.0 and I am restarting the build

@m7pr
Copy link
Contributor Author

m7pr commented Jan 22, 2025

@m7pr
Copy link
Contributor Author

m7pr commented Jan 22, 2025

@m7pr
Copy link
Contributor Author

m7pr commented Jan 24, 2025

@m7pr m7pr marked this pull request as ready for review January 24, 2025 09:37
@m7pr
Copy link
Contributor Author

m7pr commented Jan 24, 2025

@m7pr
Copy link
Contributor Author

m7pr commented Jan 24, 2025

@llrs-roche this is ready to be reviewed and merged, all jobs are green

@m7pr m7pr requested a review from llrs-roche January 24, 2025 11:28
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All scheduled actions pass now:
image

The package will only work with current Bioconductor version or later. SummarizedExperiment and MAE versions have been set to the latest. Why are they needed so high? Can this requirement be relaxed a bit?

Co-authored-by: Lluís Revilla <[email protected]>
@m7pr
Copy link
Contributor Author

m7pr commented Jan 24, 2025

Let's try @llrs-roche https://github.com/insightsengineering/hermes/actions/runs/12950574751

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
HermesData-methods 💔 $5.39$ $+1.65$ $0$ $0$ $0$ $0$
differential 💔 $28.71$ $+7.35$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
HermesData-methods 💔 $0.10$ $+1.06$ rbind_function_fails_as_expected_when_rbind_results_in_duplicated_colnames
differential 💔 $5.03$ $+2.44$ diff_expression_allows_passing_of_method_arguments_to_helper_functions
differential 💔 $9.45$ $+1.95$ h_diff_expr_deseq2_can_pass_arguments_to_DESeq2_DESeq
differential 💔 $0.90$ $+1.49$ h_diff_expr_voom_can_pass_arguments_to_limma_eBayes

Results for commit 41dbcc0

♻️ This comment has been updated with latest results.

Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed too! 🎉 This makes it easier to install and use the package! Thanks!

@llrs-roche llrs-roche self-assigned this Jan 24, 2025
@m7pr m7pr merged commit cd56c7a into main Jan 24, 2025
34 checks passed
@m7pr m7pr deleted the fix_scheduled branch January 24, 2025 14:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants