-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strict testing #202
strict testing #202
Conversation
Unit Tests Summary 1 files 2 suites 54s ⏱️ Results for commit a650019. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 7085af0 ♻️ This comment has been updated with latest results. |
#### Changes description - Add rule to object names that is CDISC and `ANL` variable friendly - Convert all `# nolint` to specific rules - Adds default option to all chunks that will remove any `# nolint` from code in Quarto Superlinter runs fine on this branch: https://github.com/insightsengineering/tlg-catalog/actions/runs/8111598641/job/22171154040 - The other linter job always fails on workflow dispatch Running `lintr::lint_dir(".")` passes without any issues  --------- Signed-off-by: André Veríssimo <[email protected]>
Signed-off-by: Pawel Rucki <[email protected]>
hi @pawelru , do you know why rbmi table changed? i don't think any dependencies was updated for this? |
I have no idea. I will revert it and see what happens |
Signed-off-by: Pawel Rucki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks Pawel! Fantastic work ;) skip_test_strict
logic you highlighted is fine for me and for now, it seems quite clean and close to the original code. Doing some exception while testing, as you wrote, would be too complicated imo
pre-commit.yaml