Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict testing #202

Merged
merged 12 commits into from
Mar 11, 2024
Merged

strict testing #202

merged 12 commits into from
Mar 11, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jan 30, 2024

  • added options for strict testing
  • add pre-commit.yaml
  • solve all lintr issues
  • solve all spelling issues

@pawelru pawelru added the sme label Jan 30, 2024
@pawelru pawelru changed the title Pre commit strict testing Jan 30, 2024
Copy link
Contributor

github-actions bot commented Jan 30, 2024

Unit Tests Summary

  1 files  2 suites   54s ⏱️
 24 tests 0 ✅  24 💤 0 ❌
296 runs  0 ✅ 296 💤 0 ❌

Results for commit a650019.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
graph-snaps 💔 $3.92$ $+1.11$ $0$ $0$ $0$ $0$
markdown-snaps 💚 $50.59$ $-1.05$ $+1$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
graph-snaps 💔 $3.02$ $+1.30$ plot_v1

Results for commit 7085af0

♻️ This comment has been updated with latest results.

averissimo and others added 4 commits March 1, 2024 14:44
#### Changes description

- Add rule to object names that is CDISC and `ANL` variable friendly
- Convert all `# nolint` to specific rules
- Adds default option to all chunks that will remove any `# nolint` from
code in Quarto

Superlinter runs fine on this branch:
https://github.com/insightsengineering/tlg-catalog/actions/runs/8111598641/job/22171154040
  - The other linter job always fails on workflow dispatch

Running `lintr::lint_dir(".")` passes without any issues


![image](https://github.com/insightsengineering/tlg-catalog/assets/211358/0e71fb3d-ce6b-484f-be65-18cf4eb9b0f3)

---------

Signed-off-by: André Veríssimo <[email protected]>
@shajoezhu
Copy link
Contributor

hi @pawelru , do you know why rbmi table changed? i don't think any dependencies was updated for this?

@pawelru
Copy link
Contributor Author

pawelru commented Mar 8, 2024

hi @pawelru , do you know why rbmi table changed? i don't think any dependencies was updated for this?

I have no idea. I will revert it and see what happens

@Melkiades Melkiades self-assigned this Mar 11, 2024
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Pawel! Fantastic work ;) skip_test_strict logic you highlighted is fine for me and for now, it seems quite clean and close to the original code. Doing some exception while testing, as you wrote, would be too complicated imo

@pawelru pawelru merged commit d17033f into main Mar 11, 2024
15 checks passed
@pawelru pawelru deleted the pre-commit branch March 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants