This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
workflows: fixes to make author dags work #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drjova
reviewed
Jul 8, 2024
|
|
||
| data = { | ||
| "$schema": "http://inspirebeta.net/schemas/records/authors.json", | ||
| "name": {"value": "PlaceHolder"}, |
There was a problem hiding this comment.
why do we need a placeholder?
There was a problem hiding this comment.
According to the name property must have a value, it must be a non empty string
drjova
reviewed
Jul 8, 2024
drjova
suggested changes
Jul 8, 2024
Comment on lines
99
to
103
| data["name"]["value"] = ( | ||
| workflow_data["data"]["data"]["given_name"] | ||
| + " " | ||
| + workflow_data["data"]["data"]["family_name"] | ||
| ) |
drjova
suggested changes
Jul 8, 2024
| @@ -48,6 +47,7 @@ def author_create_approved_dag(): | |||
|
|
|||
| @task() | |||
| def set_workflow_status_to_running(**context): | |||
| """sets status to running""" | |||
There was a problem hiding this comment.
we don't need this docstring
|
|
||
| data = { | ||
| "$schema": "http://inspirehep.net/schemas/records/authors.json", | ||
| "name": {"value": "NAME"}, |
DonHaul
force-pushed
the
main
branch
2 times, most recently
from
85fa478 to
1fe1204
Compare
drjova
reviewed
Jul 8, 2024
drjova
approved these changes
Jul 8, 2024
|
@DonHaul could you please squash? |
|
@drjova could you give me write access? I cant seem to merge |
DonHaul
force-pushed
the
main
branch
3 times, most recently
from
3771821 to
5e71e8f
Compare
|
@DonHaul could you please rebase? |
drjova
approved these changes
Jul 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.