Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version comparison and tests #147

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion atsc/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "atsc"
version = "0.7.1"
version = "0.7.2"
authors = ["Carlos Rolo <[email protected]>"]
edition = "2021"
license = "Apache-2.0"
Expand All @@ -24,6 +24,7 @@ inverse_distance_weight = "0.1.1"
num-traits = "0.2"
csv = "1.3.1"
thiserror = "2.0.3"
version-compare = "0.1"

[dev-dependencies]
criterion = "0.5.1"
Expand Down
7 changes: 5 additions & 2 deletions atsc/src/data.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ use log::debug;

#[derive(Encode, Decode, Debug, Clone)]
pub struct CompressedStream {
header: CompressorHeader,
pub header: CompressorHeader,
data_frames: Vec<CompressorFrame>,
}

Expand Down Expand Up @@ -120,7 +120,10 @@ mod tests {
let mut cs = CompressedStream::new();
cs.compress_chunk_with(&vector1, Compressor::Constant);
let b = cs.to_bytes();
assert_eq!(b, [66, 82, 82, 79, 0, 1, 41, 251, 0, 4, 3, 3, 30, 3, 1]);
assert_eq!(
b,
[66, 82, 82, 79, 5, 48, 46, 55, 46, 50, 0, 1, 41, 251, 0, 4, 3, 3, 30, 3, 1]
);
}

#[test]
Expand Down
95 changes: 94 additions & 1 deletion atsc/src/header.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,67 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

use std::panic;

use bincode::{Decode, Encode};
use log::{debug, trace};
use version_compare::{compare, Cmp};

#[derive(Encode, Decode, Debug, Clone)]
#[derive(Encode, Debug, Clone)]
pub struct CompressorHeader {
initial_segment: [u8; 4],
pub version: String,
// We should go unsigned
frame_count: i16,
}

fn verify_header_versions(header: &CompressorHeader) {
let current_version = env!("CARGO_PKG_VERSION").to_string();
trace!("Versions: c:{} h:{}", current_version, header.version);
match compare(&current_version, &header.version) {
Ok(Cmp::Lt) => panic!(
"Can't decompress! File is version ({}) is higher than compressor version ({})!",
header.version, current_version
),
Ok(Cmp::Eq | Cmp::Gt) => debug!("File version: {}", header.version),
_ => panic!("Wrong version number!"),
}
}

impl Decode for CompressorHeader {
fn decode<__D: ::bincode::de::Decoder>(
decoder: &mut __D,
) -> Result<Self, ::bincode::error::DecodeError> {
let header = Self {
initial_segment: Decode::decode(decoder)?,
version: Decode::decode(decoder)?,
frame_count: Decode::decode(decoder)?,
};
verify_header_versions(&header);
Ok(header)
}
}

impl<'__de> ::bincode::BorrowDecode<'__de> for CompressorHeader {
fn borrow_decode<__D: ::bincode::de::BorrowDecoder<'__de>>(
decoder: &mut __D,
) -> Result<Self, ::bincode::error::DecodeError> {
let header = Self {
initial_segment: bincode::BorrowDecode::borrow_decode(decoder)?,
version: bincode::BorrowDecode::borrow_decode(decoder)?,
frame_count: bincode::BorrowDecode::borrow_decode(decoder)?,
};
verify_header_versions(&header);
Ok(header)
}
}

impl CompressorHeader {
pub fn new() -> Self {
const VERSION: &str = env!("CARGO_PKG_VERSION");
CompressorHeader {
initial_segment: *b"BRRO",
version: VERSION.to_string(),
// We have to limit the bytes of the header
frame_count: 0,
}
Expand All @@ -36,3 +84,48 @@ impl CompressorHeader {
self.frame_count += 1;
}
}

#[cfg(test)]
mod tests {
use super::*;
use crate::compressor::Compressor;
use crate::data::CompressedStream;

#[test]
fn test_same_version() {
let vector1 = vec![1.0; 1024];
let mut cs = CompressedStream::new();
cs.compress_chunk_with(&vector1, Compressor::Constant);
let b = cs.to_bytes();
let cs2 = CompressedStream::from_bytes(&b);
assert_eq!(
compare(env!("CARGO_PKG_VERSION"), cs2.header.version),
Ok(Cmp::Eq)
);
}

#[test]
fn test_smaller_version() {
let vector1 = vec![1.0; 1024];
let mut cs = CompressedStream::new();
cs.header.version = "0.1.0".to_owned();
cs.compress_chunk_with(&vector1, Compressor::Constant);
let b = cs.to_bytes();
let cs2 = CompressedStream::from_bytes(&b);
assert_eq!(
compare(env!("CARGO_PKG_VERSION"), cs2.header.version),
Ok(Cmp::Gt)
);
}

#[test]
#[should_panic(expected = "is higher than compressor version")]
fn test_higher_version() {
let vector1 = vec![1.0; 1024];
let mut cs = CompressedStream::new();
cs.header.version = "9.9.9".to_owned();
cs.compress_chunk_with(&vector1, Compressor::Constant);
let b = cs.to_bytes();
CompressedStream::from_bytes(&b);
}
}