Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new configs including advertised_port and use_secured_proxy #20

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add support for new configs including advertised_port and use_secured_proxy #20

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
323df6a
Add support for new configs including advertised_port and use_secured…
Apr 19, 2022
38bd98a
Updated format.
Apr 19, 2022
00ae6ea
Merge changes from upstream.
Apr 27, 2022
ac06337
Change name from use_secured_proxy to advertised_protocol.
Apr 28, 2022
b01eebb
Change the behaviour of advertised_protocol.
Apr 29, 2022
95da78e
Removing attribute self.protocol.
May 2, 2022
901c0e3
Solving line too long error failed in CI pipeline.
May 3, 2022
7c811bb
Solving line too long error failed in CI pipeline.
May 3, 2022
c8b06cd
Solving formatting issue using black.
May 3, 2022
87e5060
Solving formatting issue using black.
May 3, 2022
fe5df0a
Get rid of multilines.
May 3, 2022
7e20823
Adding multilines back.
May 3, 2022
2df2cd1
Fixing the issue by using pre-commit.
May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions karapace/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
"group_id": "schema-registry",
"host": "127.0.0.1",
"port": 8081,
"advertised_port": None,
"use_secured_proxy": False,
"server_tls_certfile": None,
"server_tls_keyfile": None,
"registry_host": "127.0.0.1",
Expand Down
6 changes: 5 additions & 1 deletion karapace/kafka_rest_apis/consumer_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@
class ConsumerManager:
def __init__(self, config: dict) -> None:
self.config = config
self.hostname = f"http://{self.config['advertised_hostname']}:{self.config['port']}"
self.protocol = "https" if self.config["use_secured_proxy"] else "http"
if self.config["advertised_port"] is None:
self.hostname = f"{self.protocol}://{self.config['advertised_hostname']}:{self.config['port']}"
else:
self.hostname = f"{self.protocol}://{self.config['advertised_hostname']}:{self.config['advertised_port']}"
self.log = logging.getLogger("RestConsumerManager")
self.deserializer = SchemaRegistryDeserializer(config=config)
self.consumers = {}
Expand Down