Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: sebulba recurrent ippo #1156

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Conversation

SimonDuToit
Copy link
Contributor

Sebulba implementation of recurrent IPPO. Numerous changes from previous PR, now performs as expected.

Sebulba system sweep results on LBF and Rware

@sash-a sash-a changed the base branch from develop to feat/sebulba-pipeline-fix January 28, 2025 16:01
@sash-a sash-a changed the base branch from feat/sebulba-pipeline-fix to develop January 28, 2025 16:02
Copy link
Contributor

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry for all the nits, trying to cut down on how long this file is becoming. I think it would be really nice if we could use the gae util function in here if possible

Copy link
Contributor

@Louay-Ben-nessir Louay-Ben-nessir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🔥 just a few comments and suggestions!

sash-a
sash-a previously approved these changes Mar 3, 2025
Copy link
Contributor

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things, otherwise I think we can merge this 🚀

Copy link
Contributor

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants