feat: ff_ippo refactor #1160
Open
feat: ff_ippo refactor #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sash-a
requested review from
RuanJohn,
OmaymaMahjoub,
WiemKhlifi,
SimonDuToit and
Louay-Ben-nessir
as code owners
There was a problem hiding this comment.
PR Overview
This PR refactors parts of the PPO configuration by introducing a new configuration check to reduce nesting and improve code clarity.
- Added a new configuration check function "check_anakin_ppo_config" to validate PPO configurations.
- Improved configuration validation with additional assert statements.
Reviewed Changes
| File | Description |
|---|---|
| mava/utils/config.py | Added a new function for PPO configuration validation with two asserts, one of which contains a typo in the error message. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A nice refactor to reduce the nesting used in PPO and generally make the code more understandable.
Why?
I wanted to test Claude code and am pleasantly surprised with the results.
How?
I asked Claude code to refactor the code and reduce the nesting and it's done well
Note:
This doesn't need to go in now, we should decide how quickly we want to merge this considering all the other PPO based systems.
Any style changes you've wanted should be added to this PR - so check carefully!