Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Conversation

Sarthak-instill
Copy link
Member

Because

  • we need to update github action default token

This commit

  • update github action default token

@linear
Copy link

linear bot commented Oct 27, 2023

INS-2412 For public repo's PR GA workflow, we don’t need to log in to our Docker Hub.

pinglin said:

engineering For our public repos’ pull request GA workflow, we don’t need to log in to our Docker Hub. The GA secret can’t be exposed to a forked repo anyway. Also, for Codecov GA workflow, we will need to use the GitHub default token here so the pull request from a forked repo branch can also trigger the Codecov GA workflow. sarthak.gupta Can you help update the logic for all repos. Thanks.

<https://github.com/instill-ai/model-backend/blob/main/.github/workflows/coverage.yml | coverage.yml>

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (961c654) 76.49% compared to head (479f29d) 76.49%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   76.49%   76.49%           
=======================================
  Files           1        1           
  Lines         217      217           
=======================================
  Hits          166      166           
  Misses         34       34           
  Partials       17       17           
Flag Coverage Δ
unittests 76.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 merged commit f833f51 into main Oct 27, 2023
9 checks passed
@donch1989 donch1989 deleted the sarthakgupta/ins-2412-for-public-repos-pr-ga-workflow-we-dont-need-to-log-in-to branch October 27, 2023 08:40
donch1989 pushed a commit that referenced this pull request Oct 27, 2023
Because

- we need to update github action default token

This commit

- update github action default token
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
Because

- In proto, `Connector` has been renamed to `ConnectorResource`

This commit

- use `ConnectorResource_State` enum
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
Because

- we need to update github action default token

This commit

- update github action default token
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants