Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug about unit type #826

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix: fix bug about unit type #826

merged 2 commits into from
Nov 14, 2024

Conversation

chuang8511
Copy link
Member

@chuang8511 chuang8511 commented Nov 8, 2024

Because

  • we miss unit type

This commit

  • add unit type when unmarshal
  • add the logger in panic section for better debugging flow

Copy link

linear bot commented Nov 8, 2024

@donch1989 donch1989 merged commit a89fdf7 into main Nov 14, 2024
13 checks passed
@donch1989 donch1989 deleted the chunhao/ins-6788-fix-bug branch November 14, 2024 04:06
chuang8511 added a commit that referenced this pull request Nov 14, 2024
Because

- we miss unit type

This commit

- add unit type when unmarshal
- add the logger in panic section for better debugging flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants