Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Implement tracks disabling/enabling on subscribers side (#27) #127

Merged
merged 49 commits into from
Sep 17, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Aug 3, 2020

Part of #27

Synopsis

For the future PRs we need to implement remote Senders muting/unmuting.

This methods will be added to the JS-side Room:

  1. Room.mute_remote_audio

  2. Room.mute_remote_video

  3. Room.unmute_remote_audio

  4. Room.unmute_remove_video

Solution

Send Command::UpdateTracks with remote TrackIds of the all Receivers with some kind.

Store remote mute state in the Jason Room and consider it on Event::PeerCreated receiving.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) labels Aug 3, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Aug 3, 2020
@evdokimovs evdokimovs self-assigned this Aug 3, 2020
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Aug 3, 2020

FCM

Implement tracks disabling/enabling on subscribers side (#127, #27)

- expose methods for muting remote audio/video on Room API in Jason
- add remote audio/video muting to the 'e2e-demo' and 'demo' apps

@evdokimovs evdokimovs marked this pull request as ready for review August 3, 2020 15:58
@evdokimovs evdokimovs requested a review from alexlapa August 3, 2020 15:58
@alexlapa alexlapa changed the title WIP: Implement remote Senders muting/unmuting (#27) WIP: Implement tracks disabling / enabling on subscribers side (#27) Aug 3, 2020
@evdokimovs evdokimovs marked this pull request as draft August 26, 2020 12:58
@evdokimovs evdokimovs added the waiting: materials There is a need for additional actions/info outside the issue/PR to continue its solving. label Aug 26, 2020
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Aug 26, 2020

Waits for merging:

@evdokimovs evdokimovs removed the waiting: materials There is a need for additional actions/info outside the issue/PR to continue its solving. label Sep 11, 2020
@evdokimovs evdokimovs marked this pull request as ready for review September 11, 2020 16:53
@evdokimovs evdokimovs changed the title Draft: Implement tracks disabling / enabling on subscribers side (#27) Implement tracks disabling / enabling on subscribers side (#27) Sep 11, 2020
@evdokimovs evdokimovs requested a review from alexlapa September 11, 2020 16:53
@alexlapa alexlapa requested a review from tyranron September 16, 2020 13:58
@tyranron tyranron added k::deploy Related to deployment capabilities k::design Related to overall design and/or architecture and removed k::deploy Related to deployment capabilities labels Sep 17, 2020
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And merge wtih the latest master.

@evdokimovs evdokimovs changed the title Implement tracks disabling / enabling on subscribers side (#27) Implement tracks disabling/enabling on subscribers side (#27) Sep 17, 2020
@evdokimovs evdokimovs merged commit 3021b5e into master Sep 17, 2020
@evdokimovs evdokimovs deleted the senders-muting-by-subsciber branch September 17, 2020 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants