Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Rename Event::TracksUpdated to Event::PeerUpdated (#27) #139

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Rename Event::TracksUpdated to Event::PeerUpdated (#27) #139

merged 4 commits into from
Mar 19, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Sep 14, 2020 •
edited by tyranron
Loading

Part of #27

Synopsis

#138 changes purpose of Event::TracksApplied and related objects. Now this objects are used for Peer updating instead of Track.

Solution

Rename Event::TracksApplied to PeerUpdated and all related objects.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Sep 14, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Sep 14, 2020
@evdokimovs evdokimovs self-assigned this Sep 14, 2020
@alexlapa alexlapa changed the title Draft: Rename TracksUpdated to PeerUpdated (#27) Rename TracksUpdated to PeerUpdated (#27) Sep 28, 2020
@alexlapa alexlapa changed the title Rename TracksUpdated to PeerUpdated (#27) Draft: Rename TracksUpdated to PeerUpdated (#27) Sep 28, 2020
@tyranron tyranron force-pushed the master branch 5 times, most recently from 10e5ade to 39716ed Compare February 1, 2021 15:51
@evdokimovs evdokimovs force-pushed the rename-track-change branch from 3f9561c to 7a966b1 Compare March 16, 2021 18:32
@evdokimovs evdokimovs marked this pull request as ready for review March 17, 2021 13:44
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Mar 17, 2021 •
edited
Loading

FCM

Rename Event::TracksUpdated to Event::PeerUpdated (#139, #27)

@evdokimovs evdokimovs requested a review from alexlapa March 17, 2021 14:18
@alexlapa alexlapa requested a review from tyranron March 18, 2021 11:59
@tyranron tyranron changed the title Draft: Rename TracksUpdated to PeerUpdated (#27) Rename TracksUpdated to PeerUpdated (#27) Mar 19, 2021
tyranron
tyranron approved these changes Mar 19, 2021
View reviewed changes
@evdokimovs evdokimovs changed the title Rename TracksUpdated to PeerUpdated (#27) Rename Event::TracksUpdated to Event::PeerUpdated (#27) Mar 19, 2021
@evdokimovs evdokimovs merged commit ba67dea into master Mar 19, 2021
@evdokimovs evdokimovs deleted the rename-track-change branch March 19, 2021 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa