-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move check of camera TTL from state-machine to initialization #558
Comments
also, from a design-perspective - does it make sense to do this in the state-machine at all? |
I don't know about the design question, but the camera-dependency definitely needs to be parametrized. A buggy video PC can currently block up the entire task pipeline, and there is no workaround |
I don't believe it does. This should be part of the pre-session hardware preparation and not executed during the first trial. Because the length of the first trial start pulse is undefined and the Bpod out is multiplexed, our extractors have to 'guess' which pulse to assign to the first trial start event: This is very unreliable as the valve pulse is also variable in length (depends on water volume and calibration). What's more, if the first trial start pulse is missed on the FPGA (e.g. due to the DAQ starting after task starts, int-brain-lab/ibllib#909) then the first valve pulse may be erroneously interpreted as the trial start. All of this could be resolved by leaving the camera trigger out of the state machine altogether. This could be done elsewhere by manually setting Bpod high until the first Port1In event, or maybe with a pre-task state machine. |
make sure to use specific version tag when testing |
currently, when starting a session inheriting from
ActiveChoiceWorldSession
, the task blocks up if no sync pulses from the camera are received on the Bpod's behavior port during the first state of the state-machine:iblrig/iblrig/base_choice_world.py
Lines 578 to 585 in 3d16f40
could/should this state have a time-out or be entirely optional?
The text was updated successfully, but these errors were encountered: