Camera trigger #771
Open
Camera trigger #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bimac
commented
Feb 20, 2025
bimac
commented
Feb 20, 2025
| log.info(f'Waiting for {initial_delay} s') | ||
| else: | ||
| log.info('No initial delay defined') | ||
|
|
There was a problem hiding this comment.
The above looks pretty complex for what it is doing. The goal was to make things as robust and clear as possible whilst keeping things backwards compatible.
bimac
commented
Feb 20, 2025
| if dt > 0: | ||
| log.debug(f'Waiting {dt} s to achieve an ITI duration of {self.task_params.ITI_DELAY_SECS} s') | ||
| time.sleep(dt) | ||
|
|
There was a problem hiding this comment.
The above won't be needed in the first trial - hence the conditional. We want to start the state machine asap after finishing the initial delay
|
Changes unknown |
1 task
|
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic for triggering the camera and initial delay has been moved out of the state-machines for ChoiceWorldSession.