-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data source for github_actions_environment_public_key #1770
Add data source for github_actions_environment_public_key #1770
Conversation
@ijcd would you mind creating a documentation page for this new data source and linking to it in |
I believe I have added the docs correctly. Please take a look. I can't figure out how to build the website to test that, however. Any pointers?
|
|
||
t.Run("queries an environment public key without error", func(t *testing.T) { | ||
|
||
config := ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, this test will not run as the configuration is missing the required environment and repository parameters. You can look at github/data_source_github_actions_environment_secrets_test.go
for an example of how to construct a repo and environment in a test case.
@ijcd Thanks for your patience! The docs you've added look good. The make commands concerning the website are unfortunately not working (I think since the handoff from Hashicorp? I'm not positive). I've added one comment about testing this functionality and we should be good to go here once tests are all set. |
I added to the test case. I had to do this blind because I can't figure out how to get the tests to run. They either complain about things like
|
👋 Hey Friends, this pull request has been automatically marked as |
Resolves #1769
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
I'm looking for guidance on how to best test this.
I'm also looking for guidance on how to update the docs. Are they auto-generated or does one edit stuff under
website/
?Does this introduce a breaking change?
No
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Feature
Type: Documentation
Type: Maintenance