Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct update_allows_fetch_and_merge parameter in the rules mapping #2544

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yurii-kysel
Copy link

@yurii-kysel yurii-kysel commented Jan 22, 2025

Previously the update parameter was used to set the update_allows_fetch_and_merge value.
Based on the documentation it should be update_allows_fetch_and_merge in case when update is set to true

Resolves #2463


Before the change?

  • When the update parameter is set to true - update_allows_fetch_and_merge also was set to true automatically, even if we have update_allows_fetch_and_merge: false in our rules

After the change?

  • When the update parameter is set to true - update_allows_fetch_and_merge would be set based on the rule we defined in update_allows_fetch_and_merge

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@yurii-kysel
Copy link
Author

The tests were not added, as the use-case is only applicable to forked repositories (which is currently not possible to be created using the terraform). In case with the normal repo, the update_allows_fetch_and_merge would always be false in output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Property update_allows_fetch_and_merge indefinitely appear as a part of terraform plan/apply
1 participant