Enable interruption of PerfSpect with SIGINT (ctrl-c) when collecting data over SSH #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the target RunCommand interface to accept a boolean that indicates if the SSH connection can be re-used, i.e., use SSH control master.
Changed long running commands, e.g., the report collection master script, to NOT use the SSH control master. This allows SIGINT to stop child processes, e.g., ssh.
Now, if collecting remote data using the 'report' command, ctrl-c will interrupt, and stop, PerfSpect.