fix: java parser failing to match vendor on product without '-' #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, good catch. I've approved the tests to run and will be back after they're done. |
Codecov Report
@@ Coverage Diff @@
## main #2961 +/- ##
==========================================
- Coverage 82.85% 82.55% -0.30%
==========================================
Files 676 676
Lines 10665 10665
Branches 1430 1430
==========================================
- Hits 8836 8805 -31
- Misses 1459 1488 +29
- Partials 370 372 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
update commit - cleaned up black check |
if the product did not have - in name and the vendor was found it would return None even though the match was found * fixes intel#2960 Signed-off-by: Bartlomiej Cieszkowski <[email protected]>
|
updated branch |
terriko
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the product did not have - in name and the vendor was found it would return None even though the match was found