lib: Fix calloc arguments that are in the wrong order

Calloc arguments should be (number of items, size of item) but a few of these are the wrong way around, fix them. Signed-off-by: Colin Ian King <[email protected]>
intel · Jan 6, 2025 · 7930925 · 7930925
1 parent 3bae201
commit 7930925
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/acpi.c b/lib/acpi.c
@@ -586,7 +586,7 @@ acpi_get_irdt_chms(struct acpi_table_irdt_device *dev,
         size_t chms_len = dev->length - dss_size;
 
         *num = chms_len / sizeof(struct acpi_table_irdt_chms);
-        *chms = calloc(sizeof(struct acpi_table_irdt_chms *), *num);
+        *chms = calloc(*num, sizeof(struct acpi_table_irdt_chms *));
         if (!*chms) {
                 LOG_ERROR("Memory allocation failed!\n");
                 *num = 0;

diff --git a/lib/iordt.c b/lib/iordt.c
@@ -438,13 +438,13 @@ iordt_init(const struct pqos_cap *cap, struct pqos_devinfo **devinfo)
 
         acpi_print(table);
 
-        m_devinfo = (struct pqos_devinfo *)calloc(sizeof(*m_devinfo), 1);
+        m_devinfo = (struct pqos_devinfo *)calloc(1, sizeof(*m_devinfo));
         if (m_devinfo == NULL) {
                 acpi_free(table);
                 return PQOS_RETVAL_ERROR;
         }
 
-        m_mmioinfo = (struct iordt_mmioinfo *)calloc(sizeof(*m_mmioinfo), 1);
+        m_mmioinfo = (struct iordt_mmioinfo *)calloc(1, sizeof(*m_mmioinfo));
         if (m_mmioinfo == NULL) {
                 acpi_free(table);
                 free(m_devinfo);