Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Code refactoring #2035

Merged
merged 1 commit into from
Aug 28, 2024
+5 −7
Merged

[NFC] Code refactoring #2035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ target_link_libraries(triton-llvm-opt PRIVATE
)
export_executable_symbols_for_plugins(triton-llvm-opt)


add_llvm_executable(triton-tensor-layout triton-tensor-layout.cpp PARTIAL_SOURCES_INTENDED)
target_link_libraries(triton-tensor-layout PRIVATE
TritonGPUIR
Expand Down
2 changes: 1 addition & 1 deletion docs/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def setup_generated_mlir_docs():

rst_string = f"""
Triton MLIR Dialects and Ops
============================
=====================
.. toctree::
:maxdepth: 1
Expand Down
2 changes: 1 addition & 1 deletion docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Python API


Triton MLIR Dialects and Ops
----------------------------
--------------------

- :doc:`Triton MLIR Dialects and Ops <dialects/dialects>`

Expand Down
1 change: 0 additions & 1 deletion include/triton/Conversion/TritonToTritonGPU/Passes.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,4 @@ def ConvertTritonToTritonGPU: Pass<"convert-triton-to-tritongpu", "mlir::ModuleO
];
}


#endif
2 changes: 1 addition & 1 deletion third_party/nvidia/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ include_directories(${CMAKE_CURRENT_SOURCE_DIR}/include)
include_directories(${CMAKE_CURRENT_BINARY_DIR}/include)
add_subdirectory(include)
add_subdirectory(lib)
if(TRITON_BUILD_PYTHON_MODULE AND NOT DEFINED NVIDIA_DIALECTS_ONLY)
if(TRITON_BUILD_PYTHON_MODULE)
add_triton_plugin(TritonNVIDIA ${CMAKE_CURRENT_SOURCE_DIR}/triton_nvidia.cc LINK_LIBS TritonNVIDIAGPUToLLVM NVGPUToLLVM)
endif()
4 changes: 1 addition & 3 deletions unittest/Conversion/TritonGPUToLLVM/PTXAsmFormatTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
#include "intel/include/TritonIntelGPUToLLVM/PTXAsmFormat.h"
#include "nvidia/include/TritonNVIDIAGPUToLLVM/PTXAsmFormat.h"
#include "mlir/Dialect/Arith/IR/Arith.h"
#include "mlir/IR/Builders.h"
#include "triton/Dialect/Triton/IR/Dialect.h"
#include "llvm/Support/Signals.h"

#include <gtest/gtest.h>

using ::mlir::triton::intel::PTXBuilder;

namespace mlir {
namespace triton {
class PTXAsmFormatTest : public ::testing::Test {
Expand Down