Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Loop Specialization]: Specialize loops containing masked operations with loop invariant mask #3586

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+313 −141
Open

[Loop Specialization]: Specialize loops containing masked operations with loop invariant mask #3586

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4a3235b
Introduce loop versioning to remove masked tt.load operations.
etiotto Feb 24, 2025
06629ff
Fix precommit
etiotto Feb 24, 2025
bde5a8c
Fix assertion
etiotto Feb 24, 2025
22b34e1
Fix assertion
etiotto Feb 24, 2025
99f11e1
Merge remote-tracking branch 'origin/main' into etiotto.loop_versioni…
etiotto Feb 27, 2025
272d1f4
[Loop Specialization]: Specalize loops containing masked operations w…
etiotto Mar 1, 2025
81c1e11
Merge remote-tracking branch 'origin/main' into etiotto.loop_versioni…
etiotto Mar 3, 2025
f8e2da5
Address code review comments
etiotto Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/Triton/Intel/RaiseToBlockPointers/kernel-03-matrix-multiplication.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// RUN: triton-opt %s -triton-intel-remove-masks -triton-raise-block-pointer -canonicalize | FileCheck %s

module {
// COM: Derived from tutorial 03-matrix-multiplication.
tt.func public @matmul_kernel(%arg0: !tt.ptr<f16> {tt.divisibility = 16 : i32}, %arg1: !tt.ptr<f16> {tt.divisibility = 16 : i32}, %arg2: !tt.ptr<f16> {tt.divisibility = 16 : i32}, %arg3: i32 {tt.divisibility = 16 : i32}, %arg4: i32 {tt.divisibility = 16 : i32}, %arg5: i32 {tt.divisibility = 16 : i32}, %arg6: i32 {tt.divisibility = 16 : i32}, %arg7: i32 {tt.divisibility = 16 : i32}, %arg8: i32 {tt.divisibility = 16 : i32}) {
%c31_i32 = arith.constant 31 : i32
%cst = arith.constant dense<0.000000e+00> : tensor<64x128xf32>
Expand Down
2 changes: 2 additions & 0 deletions third_party/intel/backend/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@ def make_ttir(mod, metadata, opt):
pm.enable_debug()
passes.common.add_inliner(pm)
passes.ttir.add_combine(pm)
passes.common.add_cse(pm)
passes.common.add_licm(pm)
intel.passes.ttir.add_remove_masks(pm)
if raise_block_ptr_flags['enabled']:
ignore_masks = True if raise_block_ptr_flags['ignore-masks'] else False
Expand Down
Loading
Loading