Added retry mechanism and nmcli commands to set IP for host-acc comm channel. #237
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sudhar-krishnakumar
force-pushed
the
nmcli_addip
branch
3 times, most recently
from
484ec26 to
0feeadd
Compare
There was a problem hiding this comment.
Line 266: You could return here too, instead of break?
There was a problem hiding this comment.
Generally, break is considered better...than return from inside a for-loop. So if you are fine, would keep this part as-it-is.
Not required, just a good programming practice. |
sudhar-krishnakumar
force-pushed
the
nmcli_addip
branch
from
0feeadd to
83bb9ea
Compare
sudhar-krishnakumar
force-pushed
the
nmcli_addip
branch
from
83bb9ea to
b322a74
Compare
…or each interface, to stabilize and become activated. With Option2: we try to use nmcli to set IP addrtess. But during host reboot, network manager daemon is flaky, wherein even if interface(conn) does not exist in nmcli's DB, it thinks it exists, and causes issues. This function does a few retries, when it tries to set IP.
sudhar-krishnakumar
force-pushed
the
nmcli_addip
branch
from
b322a74 to
5e5de66
Compare
| if err != nil { | ||
| log.Errorf("ip link set err->%v, output->%v\n", err, output) | ||
| return fmt.Errorf("ip link set err->%v, output->%v\n", err, output) | ||
| runCmd = fmt.Sprintf(`nmcli conn show | grep -w "%s"`, intfName) |
There was a problem hiding this comment.
nmcli conn show should also specify intfName...otherwise...we end up making invalid assumption...that interface already exists....when actually....that interface name just happens...to show up in a different coloumn...as part of the output.
|
Plan to keep this branch...for a while..just for reference...in case...we want to re-surrect this for some reason. Although it will aslo need this additional change-> nmcli conn show should also specify intfName...otherwise...we end up making invalid assumption...that interface already exists....when actually....that interface name just happens...to show up in a different coloumn...as part of the output. |
Upon host reboot, it seems to take time for network-manager's state for each interface,
to stabilize and become activated. This function does a few retries,
when it tries to set IP.