Changes to detect if pkg file needs to be updated thro IMC reboot. #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saynb
approved these changes
Nov 14, 2024
| } | ||
|
|
||
| log.Infof("uuidFileExists->%v, p4pkgMatch->%v", uuidFileExists, p4pkgMatch) | ||
| return true, fmt.Sprintf("uuidFileExists->%v, p4pkgMatch->%v", uuidFileExists, p4pkgMatch) |
There was a problem hiding this comment.
Looks like we are not using return string value at the caller when the uuid file exists. Just "return turn, nil" here.
There was a problem hiding this comment.
@arunvelayutham , this is just there for any future use, on caller side.
sudhar-krishnakumar
force-pushed
the
upgrade_2
branch
from
d70c5be to
b0bccaa
Compare
In case, where ipu-plugin has a different P4 package, compared to what is on IMC using md5sum. Also added changes to detect change in load_custom_pkg.sh, with what is part of ipu-plugin module, versus, what exists on IMC.
sudhar-krishnakumar
force-pushed
the
upgrade_2
branch
4 times, most recently
from
ec9ab2f to
8b386a9
Compare
sudhar-krishnakumar
force-pushed
the
upgrade_2
branch
from
8b386a9 to
406bcf0
Compare
saynb
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves-> https://jira.devtools.intel.com/browse/ISSE-71
Handles both update cases below:
Case1(P4 package update): Changes to detect if pkg file needs to be updated thro IMC reboot.
In case, where ipu-plugin has a different P4 package,
compared to what is on IMC using md5sum.
With this PR, P4 package update will be handled.
Case2(Node policy update): Also handles case, where load_custom_pkg.sh has different entries in ipu-plugin versus on IMC.
So node policy update also gets handled.