Add Peer2Peer P4 rules independant of order of deployment, and other fixes. #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of order of deployment of VSP(ipu-plugin) on x86-host and ACC. If ipu-plugin's Init function gets invoked on ACC, prior to getting invoked on x86, then host VFs will not be setup yet. In that case, peer2peer rules can get added in CreateBridgePort or CreateNetworkFunction. Moved Deletion of P4 rules(such as PeerToPeer) at the point, where pod gets deleted, this increases the timeout period to greater than default 30 seconds, so updated vsp-ds.yaml file with increased timeout. And few misc fixes part of this PR.
arunvelayutham
approved these changes
Dec 5, 2024
saynb
reviewed
Dec 5, 2024
e2e/artefacts/k8s/vsp-ds.yaml
Outdated
| type: "" | ||
| name: host-opt | ||
| - hostPath: | ||
| path: /lib/modules |
There was a problem hiding this comment.
this one is not present in volumeMounts list. Intentional?
| return fmt.Errorf("No NFs initialized on the host") | ||
| // If ipu-plugin's Init function gets invoked on ACC, prior to getting invoked | ||
| // on x86, then host VFs will not be setup yet. In that case, peer2peer rules | ||
| // can get added in CreateBridgePort or CreateNetworkFunction. |
There was a problem hiding this comment.
Not sure I understood. "Can get added" or "will get added"? Does the dpu daemon have to send those or will the ipu plugin have intelligence to automatically program those?
There was a problem hiding this comment.
It can get added anywhere...depending on the sequence. Either in configureFXP or CreateBridgePort or CreateNetworkFunction.
saynb
reviewed
Dec 5, 2024
saynb
approved these changes
Dec 5, 2024
saynb
reviewed
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to ensure that Peer2Peer P4 rules, will get added, independant, of order of deployment of VSP(ipu-plugin) on x86-host and ACC. If ipu-plugin's Init function gets invoked on ACC, prior to getting invoked on x86, then host VFs will not be setup yet. In that case, peer2peer rules can get added in CreateBridgePort or CreateNetworkFunction. Moved Deletion of P4 rules(such as PeerToPeer) at the point, where pod gets deleted, this increases the timeout period to greater than default 30 seconds, so updated vsp-ds.yaml file with increased timeout. And few misc fixes part of this PR.